Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复fork抓取不全 #1563 #1565

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

saurlax
Copy link

@saurlax saurlax commented Nov 6, 2024

What this PR does / why we need it?

这个 PR 修复了 #1563 关于 fork 抓取的问题

Summary of your change

  • 在 fork_child 和 Fork 的构造函数中添加了一个 root_url 表示真正的抓取根目录
  • 更新 get_child_link_list 的逻辑为:
    • 若链接以 / 开头则用 root_url 拼接
    • 否则如果链接本身包含 root_url,直接添加
    • 否则使用 base_url 拼接

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

Copy link

f2c-ci-robot bot commented Nov 6, 2024

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

f2c-ci-robot bot commented Nov 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant