-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for GA publish and CI builds for Python 3.8, 3.9, 3.10, and 3.11 #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dmichaels-harvard
commented
Oct 6, 2023
•
edited
Loading
edited
- Fixed GA publish which was not working because it could not find dcicutils because it is not a dependency in pyproject.toml; workaround is to call it manually via straight python and not via pyproject.toml script. N.B. It still does not work because pypi project credentials are not yet defined for this repo.
- Added Python 3.8, 3.9, 3.10, as well as 3.11 for GA CI build. This caused failures because of the way the tests were written - writing/reading to/from fixed location in S3 - which means that concurrent runs do not reliably succeed, i.e. because they are stomping on each other. Workaround was to define separate build steps (cloned for now) in main.yml with appropriate "needs" clauses which forces them to execute serially. (The real fix of course is to fix this tests - and note of course they tests can still fail if someone somewhere happens to be running the tests locally at the same time)
…rency issue in GA.
dmichaels-harvard
requested review from
netsettler,
alexander-veit and
willronchetti
October 6, 2023 02:44
alexander-veit
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks ok to me. Certainly, the tests should be rewritten, so that the sequential GA testing is not necessary. But... that's a lot of work.
willronchetti
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.