-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Python 3.12 #406
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alex V should deploy/test this out before merging
@@ -143,3 +143,34 @@ jobs: | |||
- name: QA (unit) | |||
run: | | |||
poetry run invoke test --no-flake | |||
|
|||
build_3_12: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just realized this build is not defined correctly - you can re-use all the below by using the matrix
syntax, see https://github.com/4dn-dcic/utils/blob/master/.github/workflows/main.yml#L24-L26 as an example
I am getting
This is exptected with Python 3.12: https://docs.python.org/dev/whatsnew/3.12.html#other-language-changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I deployed it and ran a test workflow and everything seems to work for Python 3.12. I would just modify the regex expressions to avoid the syntax warnings, e.g., replace
filename = re.match('(.+)\.{0}$'.format(unzip), filename).group(1)
with
filename = re.match(r'(.+)\.{0}$'.format(unzip), filename).group(1)
No description provided.