Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi language image descriptions #2792

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Mar 18, 2024

What is this pull request for?

Create a language based picture description model and UI to choose the description by language

Screenshots

Alchemy CMS - Bilder 2024-04-11 20-19-20

Alchemy CMS - Bilder 2024-04-11 20-19-30

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@tvdeyen tvdeyen added this to the 7.2 milestone Mar 18, 2024
@tvdeyen tvdeyen force-pushed the multi-language-image-descriptions branch 3 times, most recently from 2ade9f3 to e6339fd Compare April 11, 2024 20:54
@tvdeyen tvdeyen changed the title wip: multi language image descriptions Add multi language image descriptions Apr 11, 2024
@tvdeyen tvdeyen marked this pull request as ready for review April 11, 2024 20:56
@tvdeyen tvdeyen requested a review from a team as a code owner April 11, 2024 20:56
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.86%. Comparing base (eae9842) to head (49a2cc9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2792      +/-   ##
==========================================
+ Coverage   95.84%   95.86%   +0.01%     
==========================================
  Files         227      229       +2     
  Lines        6186     6208      +22     
==========================================
+ Hits         5929     5951      +22     
  Misses        257      257              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member Author

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Fix ingredient picture edit (needs CurrentLanguage)
  • Add tests for PictureDescriptionsController

@tvdeyen tvdeyen force-pushed the multi-language-image-descriptions branch 3 times, most recently from 75e1090 to a7bad6d Compare April 12, 2024 17:20
@tvdeyen tvdeyen force-pushed the multi-language-image-descriptions branch from a7bad6d to 49a2cc9 Compare April 12, 2024 17:37
@tvdeyen tvdeyen merged commit 5f1790c into main Apr 15, 2024
35 checks passed
@tvdeyen tvdeyen deleted the multi-language-image-descriptions branch April 15, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants