Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always show headline level #2825

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Apr 10, 2024

What is this pull request for?

But disable it if only one option is available. Gives the
author some visual feedback on the headline level.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

But disable it if only one option is available. Gives the
author some visual feedback on the headline level.
Instead of title - that has lots of accessibility issues -
we use our established Shoelace Tooltip.
@tvdeyen tvdeyen added this to the 7.2 milestone Apr 10, 2024
@tvdeyen tvdeyen requested a review from a team as a code owner April 10, 2024 07:35
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.92%. Comparing base (e2f9520) to head (a6e6675).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2825   +/-   ##
=======================================
  Coverage   95.92%   95.92%           
=======================================
  Files         225      225           
  Lines        6128     6128           
=======================================
  Hits         5878     5878           
  Misses        250      250           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen merged commit 0c76560 into AlchemyCMS:main Apr 10, 2024
35 checks passed
@tvdeyen tvdeyen deleted the always-show-headline-level branch April 10, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants