Upstream update MAV_CMD_DO_FLIGHTTERMINATION enum #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
reviewed
Mar 23, 2022
| Support for this command can be tested using the protocol bit: MAV_PROTOCOL_CAPABILITY_FLIGHT_TERMINATION. | ||
| Support for this command can also be tested by sending the command with param1=0 (< 0.5); the ACK should be either MAV_RESULT_FAILED or MAV_RESULT_UNSUPPORTED. | ||
| </description> | ||
| <param index="1" label="Terminate" minValue="0" maxValue="1" increment="1">Flight termination activated if > 0.5. Otherwise not activated and ACK with MAV_RESULT_FAILED.</param> |
peterbarker
reviewed
Mar 23, 2022
| <param index="1" label="Terminate" minValue="0" maxValue="1" increment="1">Flight termination activated if > 0.5</param> | ||
| <description>Terminate flight immediately. | ||
| Flight termination immediately and irreversably terminates the current flight, returning the vehicle to ground. | ||
| The vehicle will ignore RC or other input until it has been power-cycled. |
There was a problem hiding this comment.
This is simply not true for ArduPilot, and potentially a dangerous assumption to make.
peterbarker
reviewed
Mar 23, 2022
| <description>Terminate flight immediately</description> | ||
| <param index="1" label="Terminate" minValue="0" maxValue="1" increment="1">Flight termination activated if > 0.5</param> | ||
| <description>Terminate flight immediately. | ||
| Flight termination immediately and irreversably terminates the current flight, returning the vehicle to ground. |
There was a problem hiding this comment.
ArduPilot can be configured to actually land the vehicle, not crash it.
There was a problem hiding this comment.
OK, I did not know that. Which parameter does it?
There was a problem hiding this comment.
// @Param: TERM_ACTION
// @DisplayName: Terminate action
// @Description: This can be used to force an action on flight termination. Normally this is handled by an external failsafe board, but you can setup ArduPilot to handle it here. Please consult the wiki for more information on the possible values of the parameter
// @User: Advanced
AP_GROUPINFO("TERM_ACTION", 6, AP_AdvancedFailsafe, _terminate_action, 0),
with TERMINATION_ACTION_LAND
if (_terminate_action == TERMINATE_ACTION_LAND) {
copter.set_mode(Mode::Number::LAND, ModeReason::TERMINATE);
} else {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.