Google tests framework for UnitTests #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CedricGuillemet
changed the title
Co-authored-by: Gary Hsu <[email protected]>
Co-authored-by: Gary Hsu <[email protected]>
…nto gtests # Conflicts: # CMakeLists.txt
bghgary
reviewed
Sep 6, 2023
Co-authored-by: Gary Hsu <[email protected]>
bghgary
approved these changes
Sep 20, 2023
Co-authored-by: Gary Hsu <[email protected]>
Co-authored-by: Gary Hsu <[email protected]>
Co-authored-by: Gary Hsu <[email protected]>
Co-authored-by: Gary Hsu <[email protected]>
Co-authored-by: Gary Hsu <[email protected]>
Co-authored-by: Gary Hsu <[email protected]>
bghgary
reviewed
Sep 20, 2023
Comment on lines
+69
to
+75
| if(WIN32) | ||
| # For Windows: Prevent overriding the parent project's compiler/linker settings | ||
| # Default build type for my test projects are /MDd (MultiThreaded DLL) but GTests default to /MTd (MultiTreaded) | ||
| # see https://github.com/google/googletest/blob/main/googletest/README.md | ||
| # "Enabling this option will make gtest link the runtimes dynamically too, and match the project in which it is included." | ||
| set(gtest_force_shared_crt OFF CACHE BOOL "" FORCE) | ||
| endif() |
There was a problem hiding this comment.
nit: There are tabs here instead of spaces. Also spelling errors "MultiTreaded"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- added life cycle testNotes for Android:
Android Emulator freezes on the CI when running the test. It's not related to the stdout/logcat pipeline (I've tested it). And it does not repro locally.
Most of this change is the Android project.