Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rustls compile time implementation #56

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

coco-speed
Copy link
Collaborator

This pull request was created automatically by CodSpeed to track performance changes of the pull request cloudflare/pingora#336.

The original branch is fork-336-hargut/feat/rustls-compile-time-feature

Copy link

codspeed-hq bot commented Jul 24, 2024

CodSpeed Performance Report

Merging #56 will not alter performance

Comparing fork-336-hargut/feat/rustls-compile-time-feature (f56d04e) with main (519d1f8)

Summary

✅ 2 untouched benchmarks

use generics instead as used within the original version
remove trait implementations for Box<dyn IO + Send> as no longer required
 replace direct field access with getter method that
 returns &Arc<impl TlsConnectorContext>,
 store concrete type in now private struct field

using impl Trait in return value keeps method signature
stable across features; allows for static dispatch

 adjust visibility for TlsConnectorCtx structs from pub(crate) to pub(super)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants