Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init influxdb2 support #47

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

BCNelson
Copy link

@BCNelson BCNelson commented Mar 2, 2022

This is the Initial support for version 2 of the influxdb protocol. it is mostly useful for remote instances of influxdb that need to be on version 2.

@BCNelson BCNelson marked this pull request as draft March 2, 2022 05:06
@BCNelson
Copy link
Author

BCNelson commented Mar 5, 2022

@David00 Just looking for your thoughts on things that need to be changed

@David00
Copy link
Owner

David00 commented Mar 5, 2022

Hi BCNelson, thanks for putting this together! I haven't tested it yet, but after reviewing it, the only thing I would want to have changed is the default DB version to 1 in config.py. This is mainly so that I don't have to go redo my documentation and test all the dashboards.

I was not familiar with #!/usr/bin/env instead of #!/usr/bin/python but I found this info which provided some interesting context. It shouldn't make a difference in my project as users should be launching it with python3 power-monitor.py but it was interesting to learn about, so thanks! I could even do away with the shebang altogether, actually.

Are there any benefits that moving to Influx 2.0 would bring my project? I understand they're moving to their Flux query language in 2.0 but I haven't used it.

@BCNelson
Copy link
Author

BCNelson commented Mar 6, 2022

@David00 Leaving out the version number is the same as setting it to version 1. I believe that is even better backwards compatibility.

@BCNelson
Copy link
Author

BCNelson commented Mar 6, 2022

As far as I can tell there are not many benefits to version 2 of influxdb. I'm not an influxdb expert by any means. My motivation was to be able to use a central db server and one of my other services needed v2.

influx_interface.py Outdated Show resolved Hide resolved
@luisfocosta
Copy link

Works like a charm! Thanks
One central InfluxDB to rule them all
I rather prefer the version 2 interface and data exploration GUI

@kizniche
Copy link
Contributor

kizniche commented May 17, 2022

A drawback to influxdb 2 is it drops 32-bit arm support, so it won't work on <= Pi 3

@BCNelson
Copy link
Author

@kizniche this is just the influx client witch does support 32bit arm. It is just a http api. I don't think that there is a need to have the influxdb 2 server on the pi as I did this to have a central influx server.

@kizniche
Copy link
Contributor

kizniche commented May 17, 2022

I exclusively use the influxdb server on Raspberry Pis. I'm just mentioning it because it's an important point to consider for the software component of hardware designed for a Raspberry Pi, since it would be excluding support for the vast majority of Pis that currently exist.

Edit: if this is only expanding the ability to use influxdb2 in addition to influxdb1, then that sounds like a good addition. I just wanted to mention the current need for influxdb1 for most Pis. It appears to be a misunderstanding on my part that this PR may have affected the ability to use influxdb1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants