Adds <ViveCraftPlayerTag.rotation[head/left/right]> tag for Vivecraft
#434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmonkey4eva
approved these changes
Aug 27, 2024
tal5
reviewed
Sep 30, 2024
| rotation = (float[]) object.getPlayer().getMetadata("righthand.rot").get(0).value(); | ||
| break; | ||
| default: | ||
| attribute.echoError("Attribute must be 'head', 'left' or 'right'"); |
There was a problem hiding this comment.
LGTM, just one nitpick - don't think Attribute is right here? can probably say input, input part, or format it like Invalid player part specified, must be 'head', 'left', or 'right'. or something like that
tal5
reviewed
Oct 1, 2024
| return null; | ||
| } | ||
| if (rotation == null) { | ||
| attribute.echoError("Location is not valid. Did a plugin overwrite the data?"); |
There was a problem hiding this comment.
In this case it's rotation, not location
tal5
reviewed
Oct 31, 2024
| switch (input.toString()) { | ||
| case "head": | ||
| rotation = (float[]) object.getPlayer().getMetadata("head.rot").get(0).value(); | ||
| break; |
There was a problem hiding this comment.
Can use the modern switch syntax here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested by Behr long ago in a voice call.
<ViveCraftPlayerTag.rotation[head/left/right]>tag with a QuaternionTag output.positiontag.