Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect resizing of sidenav #6512

Open
wants to merge 1 commit into
base: v1-dev
Choose a base branch
from

Conversation

stefvanschie
Copy link

@stefvanschie stefvanschie commented Feb 7, 2020

Proposed changes

This fixes issue #6350. When the sidenav is in non-fixed mode and opened, then the window is maximized making the window wider than it was previously, the darkening effect of the sidenav would stay. This has now been changed, so the darkening effect properly disappears.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

When the sidenav is in non-fixed mode and opened, then the window is maximized making the window wider than it was previously, the darkening effect of the sidenav would stay. This has now been changed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant