Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix frontend tests #1126

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fix frontend tests #1126

wants to merge 3 commits into from

Conversation

notoraptor
Copy link
Collaborator

Description

Fix failing frontend tests, last example here: https://github.com/Epistimio/orion/actions/runs/7137478292/job/19437604432

Changes

  • Use latest version of selenium
  • Update tests to correctly set Firefox browser to headless mode with latest version of selenium

Checklist

Tests

  • I added corresponding tests for bug fixes and new features. If possible, the tests fail without the changes
  • All new and existing tests are passing ($ tox -e py38; replace 38 by your Python version if necessary)

Documentation

  • I have updated the relevant documentation related to my changes

Quality

  • I have read the CONTRIBUTING doc
  • My commits messages follow this format
  • My code follows the style guidelines ($ tox -e lint)

bouthilx
bouthilx reviewed Dec 11, 2023
View reviewed changes
tests/requirements.txt Outdated Show resolved Hide resolved
bouthilx
bouthilx approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@bouthilx bouthilx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bouthilx bouthilx bouthilx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notoraptor @bouthilx