Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pimd: MSDP per peer SA limit #17521

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rzalamena
Copy link
Member

MSDP feature to help limit the amount of SAs a peer can learn. This is useful to keep the amount of SAs to a certain amount or to handle misconfigured peers.

Add MSDP shutdown and SA limiting configuration to YANG model.

(no implementation, just boiler plate code)

Signed-off-by: Rafael Zalamena <[email protected]>
@rzalamena rzalamena added documentation tests Topotests, make check, etc pim labels Nov 26, 2024
@frrbot frrbot bot added the yang label Nov 26, 2024
pimd/pim_msdp.h Outdated
@@ -152,6 +152,9 @@ struct pim_msdp_peer {
char *acl_in;
/** SA output access list name. */
char *acl_out;

/** SA maximum amount. */
size_t sa_limit;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since the limit is 4billion why not a uint32_t?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, makes sense.

Implement a command to enable/disable per peer MSDP SA limiting.

Signed-off-by: Rafael Zalamena <[email protected]>
Test that only the limit amount of SAs is learned from the peer.

Signed-off-by: Rafael Zalamena <[email protected]>
Let user know about the new MSDP SA limit command.

Signed-off-by: Rafael Zalamena <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants