Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CellIterator for subdomains #794

Merged
merged 5 commits into from
Sep 17, 2023
Merged

Fix CellIterator for subdomains #794

merged 5 commits into from
Sep 17, 2023

Conversation

kimauth
Copy link
Member

@kimauth kimauth commented Sep 17, 2023

Fixes the CellIterator for the case where only a subset of cells is part of the DofHandler. In particular this was problematic when cell 1 was not part of any SubDofHandler.

Bugfix for bug in vtk export of L2-Projection on subdomain that was reported on Slack last week.

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.10% 🎉

Comparison is base (7e8a571) 92.63% compared to head (31853db) 92.73%.
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #794      +/-   ##
==========================================
+ Coverage   92.63%   92.73%   +0.10%     
==========================================
  Files          33       33              
  Lines        4940     4942       +2     
==========================================
+ Hits         4576     4583       +7     
+ Misses        364      359       -5     
Files Changed Coverage Δ
src/Dofs/DofHandler.jl 94.83% <100.00%> (+0.79%) ⬆️
src/iterators.jl 94.69% <100.00%> (+1.56%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fredrikekre fredrikekre merged commit a4eb8a3 into master Sep 17, 2023
5 of 6 checks passed
@fredrikekre fredrikekre deleted the ka/fix_vtk_export branch September 17, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants