Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Video description collapsible and no longer hijacks page scroll #5665

Open
wants to merge 18 commits into
base: development
Choose a base branch
from
Open

Fix: Video description collapsible and no longer hijacks page scroll #5665

wants to merge 18 commits into from
+120 −2

Commits on Sep 7, 2024

  1. fix: description no longer hijacks scroll focus 

    introduced a button in video descriptions shwon as 'Click to View Description'
which allows the user to see the full description and scroll within
the description card.
    @sabs21
    sabs21 committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    671fe01 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2024

  1. fix: 'Click to View Description' button only shown for long descriptions 

    description length is based on computed css height of description
container
    @sabs21
    sabs21 committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    8bba22f View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Merge branch 'development' into fix_desc_scroll_steal

    @sabs21
    sabs21 committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    1699c6f View commit details
    Browse the repository at this point in the history

  2. Adjusted locale

    @sabs21
    sabs21 committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    219f827 View commit details
    Browse the repository at this point in the history

  3. adjusted styling to closer match YT description styling; made 

    isShortDescription simpler and less fragile
    @sabs21
    sabs21 committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    df87654 View commit details
    Browse the repository at this point in the history

  4. updated comment within onMounted

    @sabs21
    sabs21 committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    f2e4287 View commit details
    Browse the repository at this point in the history

  5. ...more button is now inline with description text

    @sabs21
    sabs21 committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    a3bf36f View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. removed underline from description status

    @sabs21
    sabs21 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    85e025d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'development' into fix_desc_scroll_steal

    @sabs21
    sabs21 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    daabdbd View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Merge branch 'development' into fix_desc_scroll_steal_2

    @sabs21
    sabs21 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    b144302 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'development' into fix_desc_scroll_steal

    @sabs21
    sabs21 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    369f9d1 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'fix_desc_scroll_steal_2' into fix_desc_scroll_steal

    @sabs21
    sabs21 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    0a6c6e5 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Merge branch 'development' into fix_desc_scroll_steal

    @sabs21
    sabs21 committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    80d19bb View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. more... button is now accessible by tab; description overlay now igno… 

    …red when tabbing
    @sabs21
    sabs21 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    5c900f9 View commit details
    Browse the repository at this point in the history

  2. readded role=button attributes

    @sabs21
    sabs21 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    823d53c View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. show more and show less buttons are now tabbed to first before 

    description links
    @sabs21
    sabs21 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    861c4b9 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. changed visual ordering of 'show less' button

    @sabs21
    sabs21 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    8a033a9 View commit details
    Browse the repository at this point in the history

  2. reverted previous change; added top margin to show less button

    @sabs21
    sabs21 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    2acb8c7 View commit details
    Browse the repository at this point in the history