Local Input Config for Keyboard #1067
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably doesn't impact this PR, but there are some open questions about how to handle keymaps across platforms: #786 |
Hoikas
added
Enhancement
Hoikas
reviewed
Feb 25, 2022
| PtDebugPrint("xIniInput::ConstructFilenameAndPath(): Using internal \"" + gFilenameAndPath + "\" file") | ||
| return | ||
| # otherwise, use the standard init path | ||
| gFilenameAndPath = PtGetInitPath() + "/" + gFilename |
There was a problem hiding this comment.
This should probably return the path instead of stashing it as a global variable. That way, you can get rid of the gFilenameAndPath thing and just do gIniFile.writeFile(ConstructFilenameAndPath()).
| controlStr = km.convertControlCodeToString(control_code) | ||
| key1 = km.convertVKeyToChar(km.getBindingKey1(control_code), km.getBindingFlags1(control_code)) | ||
| key2 = km.convertVKeyToChar(km.getBindingKey2(control_code), km.getBindingFlags2(control_code)) | ||
| xIniInput.SetControlKey('"' + controlStr + '"', key1 + ',', key2 + ',') |
There was a problem hiding this comment.
These string concats are very difficult for me to read because it uses two different kinds of quotation marks. I'd prefer to see these become f-strings.
|
Erroneously auto-closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the keymap to become global and persist through character creations.
If no keymap is found it uses the vault keymap until you go into the keymap settings and change a single keybind.