Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: bumps minimum required Starlight version to 0.28.0 #7

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

o-az
Copy link
Contributor

@o-az o-az commented Sep 20, 2024

Describe the pull request

because of this breaking change it's currently not possible to use this beautiful theme in starlight projects that use up to date version of @astrojs/starlight

Why

upgrading starlight version makes the theme compatible with the up to date version

How

How were these changes implemented?

updated starlight peerDep, which required upgrading astro

Screenshots

If applicable, add screenshots to help explain what is being modified.

related issue: #8

Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
starlight-theme-rapide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 2:10pm

Copy link
Owner

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution 🙌

It looks like quite a few more packages got updated than the one changed in the various package.json files and broke CI. I took the liberty of fixing that so we can merge this PR.

@HiDeoo HiDeoo changed the title chore: upgrade to support current starlight version feat!: bumps minimum required Starlight version to 0.28.0 Sep 20, 2024
@HiDeoo HiDeoo merged commit 165b89b into HiDeoo:main Sep 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants