Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib*: migrate to pkgconf (part 3) #199018

Merged
merged 24 commits into from
Nov 26, 2024
Merged

lib*: migrate to pkgconf (part 3) #199018

merged 24 commits into from
Nov 26, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Nov 26, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@cho-m cho-m added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-skip-dependents Pass --skip-dependents to brew test-bot. CI-no-bottles Merge without publishing bottles labels Nov 26, 2024
Copy link
Contributor

Hi, thanks for your contribution to Homebrew! ❤️

You already have >=15 open pull requests, so please get them ready to be merged or close them before you open more. If CI fails on any of them, please fix it or ask for help doing so.

If you are performing simple version bumps, @BrewTestBot automatically bumps a list of formulae so you don't need to. Please take a look at issues and pull requests labelled help wanted Task(s) needing PRs from the community or maintainers and see if you can help to fix any of them. Thanks!

@cho-m cho-m marked this pull request as ready for review November 26, 2024 04:18
@cho-m cho-m added the long build Set a long timeout for formula testing label Nov 26, 2024
@cho-m cho-m disabled auto-merge November 26, 2024 13:49
@cho-m cho-m enabled auto-merge November 26, 2024 14:31
@cho-m cho-m disabled auto-merge November 26, 2024 14:37
@cho-m cho-m enabled auto-merge November 26, 2024 15:11
@cho-m cho-m added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Nov 26, 2024
@cho-m cho-m disabled auto-merge November 26, 2024 17:20
@cho-m
Copy link
Member Author

cho-m commented Nov 26, 2024

Got hit with some GNOME server issue. Will do a syntax only since GNOME formulae all passed in prior run.

libhttpserver may need a longer timeout on x86_64 runner, but should be unrelated to pkgconf.

@cho-m cho-m removed the long build Set a long timeout for formula testing label Nov 26, 2024
@cho-m cho-m added this pull request to the merge queue Nov 26, 2024
Merged via the queue into master with commit c118fbf Nov 26, 2024
18 of 24 checks passed
@cho-m cho-m deleted the pkgconf-migrations-lib-3 branch November 26, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-skip-dependents Pass --skip-dependents to brew test-bot. CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants