update pre-commit config #2683
Open
update pre-commit config #2683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllentDan
reviewed
Oct 30, 2024
| hooks: | ||
| - id: flake8 | ||
| args: ["--exclude=lmdeploy/turbomind/triton_models/*,lmdeploy/pytorch/modeling/*", "--max-line-length=79"] | ||
| args: ["--exclude=lmdeploy/pytorch/modeling/*"] |
There was a problem hiding this comment.
直接删掉是否会出现代码极长这种，可能会比较难看？要不要设置一个比较大的，比如 vscode 的 editor.rulers 推荐的分别是 80 和 120。
There was a problem hiding this comment.
新环境里试了下，pre-commit 还是会报E501,貌似pep8默认要求就是79
lmdeploy/pytorch/models/deepseek_v2.py:11:80: E501 line too long (114 > 79 characters)
lmdeploy/pytorch/models/deepseek_v2.py:21:80: E501 line too long (121 > 79 characters)
lmdeploy/pytorch/models/deepseek_v2.py:23:1: E302 expected 2 blank lines, found 1
There was a problem hiding this comment.
As I checked, that's modified by yapf instead of flake8. I will investigate more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
"--max-line-length=79" is inappropriate for lmdeploy
Changes
refer to mmcv, mmdetection and opencompass to update pre-commit config