Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Little fix for the scroll speed crash #15

Merged
merged 7 commits into from
Aug 25, 2023

Conversation

moxie-coder
Copy link
Collaborator

I can't test if this works rn since I'm a little occupied rn

@JordanSantiagoYT
Copy link
Owner

a image

@Stefan2008Git
Copy link

a image

Tween issue
It's seems like you are missing something LMAO

@moxie-coder
Copy link
Collaborator Author

a image

Tween issue It's seems like you are missing something LMAO

lol, of course

@JordanSantiagoYT
Copy link
Owner

IMG_9212
hmmmm

@moxie-coder
Copy link
Collaborator Author

it very much might be a tween issue

@JordanSantiagoYT
Copy link
Owner

i think it may be a tween issue!!

@JordanSantiagoYT
Copy link
Owner

tested, but now Change Scroll Speed only works if value 2 is either null or 0

image

2023-08-24.15-07-40.mp4

@JordanSantiagoYT
Copy link
Owner

JordanSantiagoYT commented Aug 24, 2023

IMG_9212 hmmmm

the issue probably has something to do with this, specifically the "if (isSustainNote)" thing

@moxie-coder
Copy link
Collaborator Author

moxie-coder commented Aug 24, 2023

IMG_9212 hmmmm

the issue probably has something to do with this, specifically the "if (isSustainNote)" thing

that's for resizing the sustains, it checks first if it's a sustain note, then the middle part of the sustain and not the end, so when it tweens it won't look wonky, but I might try and checking if the sustain length is greater then zero, because when you use the skip time, it kills notes which effect sustain notes too. so If we check the sustain length, maybe this will fix it

@JordanSantiagoYT
Copy link
Owner

JordanSantiagoYT commented Aug 24, 2023

tested!! it works, only issue left to fix now is the hold notes

2023-08-24.15-46-47.mp4

reupload, didnt embed apparently

@moxie-coder
Copy link
Collaborator Author

damn

@JordanSantiagoYT
Copy link
Owner

the hold notes acting weird is probably because i added a “!Math.isNaN(sustainLength)” check to the entire thing (which probably isn’t needed)

@moxie-coder
Copy link
Collaborator Author

the hold notes acting weird is probably because i added a “!Math.isNaN(sustainLength)” check to the entire thing (which probably isn’t needed)

it might be because of the cliprect

@Stefan2008Git
Copy link

tested!! it works, only issue left to fix now is the hold notes

2023-08-24.15-46-47.mp4
reupload, didnt embed apparently

OS Engine moment

@JordanSantiagoYT
Copy link
Owner

i think i found a fix

@JordanSantiagoYT
Copy link
Owner

public function resizeByRatio(ratio:Float) //haha funny twitter shit
{
	if(isSustainNote && animation != null && animation.curAnim != null && !animation.curAnim.name.endsWith('end'))
	{
		scale.y *= ratio;
		updateHitbox();
	}
}

this may be the fix

@moxie-coder
Copy link
Collaborator Author

mk

@JordanSantiagoYT JordanSantiagoYT merged commit 2bb55d6 into JordanSantiagoYT:main Aug 25, 2023
1 of 3 checks passed
@moxie-coder moxie-coder deleted the MemeHovy-patch-1 branch August 25, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants