-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Little fix for the scroll speed crash #15
Little fix for the scroll speed crash #15
Conversation
it very much might be a tween issue |
i think it may be a tween issue!! |
that's for resizing the sustains, it checks first if it's a sustain note, then the middle part of the sustain and not the end, so when it tweens it won't look wonky, but I might try and checking if the sustain length is greater then zero, because when you use the skip time, it kills notes which effect sustain notes too. so If we check the sustain length, maybe this will fix it |
tested!! it works, only issue left to fix now is the hold notes 2023-08-24.15-46-47.mp4reupload, didnt embed apparently |
damn |
the hold notes acting weird is probably because i added a “!Math.isNaN(sustainLength)” check to the entire thing (which probably isn’t needed) |
it might be because of the cliprect |
OS Engine moment |
i think i found a fix |
this may be the fix |
mk |
I can't test if this works rn since I'm a little occupied rn