Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Android support since Jordan wanted that #18

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Adding Android support since Jordan wanted that #18

merged 1 commit into from
Aug 31, 2023

Conversation

Stefan2008Git
Copy link

_ It's W.I.P because i need to add more functions!

_ It's W.I.P because i need to add more functions!
@JordanSantiagoYT
Copy link
Owner

gameplay changers substate line 372 fix
if(controls.RESET && FlxG.keys.pressed.SHIFT #if android || virtualPad.buttonC.justPressed #end)

@Stefan2008Git
Copy link
Author

gameplay changers substate line 372 fix if(controls.RESET && FlxG.keys.pressed.SHIFT #if android || virtualPad.buttonC.justPressed #end)

Uhhhhhh
I don't know XD. Tried my best

@JordanSantiagoYT
Copy link
Owner

i'll merge it for right now and fix it from there

@JordanSantiagoYT JordanSantiagoYT merged commit 9b4614d into JordanSantiagoYT:main Aug 31, 2023
0 of 3 checks passed
@JordanSantiagoYT
Copy link
Owner

a whoopsie
image

@JordanSantiagoYT
Copy link
Owner

JordanSantiagoYT commented Aug 31, 2023

some android stuff is missing so that would be a cause for most of the errors here

@Stefan2008Git
Copy link
Author

some android stuff is missing so that would be a cause for most of the errors here

Opps, my bad

@Stefan2008Git
Copy link
Author

I told you it's W.I.P because it's missing some stuff and functions dude, so that's why

@Stefan2008Git
Copy link
Author

some android stuff is missing so that would be a cause for most of the errors here

Well, you should use MaysLastPlays fork of extension-androidtools for SUtil because it's required

@JordanSantiagoYT
Copy link
Owner

image
well i mean it does install that fork of extension-androidtools

@Stefan2008Git
Copy link
Author

image well i mean it does install that fork of extension-androidtools

Did you installed tho?

@JordanSantiagoYT
Copy link
Owner

image
pretty sure yeah

@Stefan2008Git
Copy link
Author

image pretty sure yeah

Uhhh, can you check it simply typing: "haxelib list"?

@JordanSantiagoYT
Copy link
Owner

image

@JordanSantiagoYT
Copy link
Owner

oh yeah were doing this in the github workflow

@Stefan2008Git
Copy link
Author

a whoopsie image

You should delete this stuff and add it:

  1. For OptionsState add var customizeAndroidControlsTipText:FlxText;
  2. For FlxHitbox detele a backend.ClientPrefs, ClientPrefs.hitboxAlpha and for FlxButton delete backend.ClientPrefs, ClientPrefs.virtualPadAlpha because i forgot to delete that
  3. Delete on AndroidControlsSubState var velocityBackground:FlxBackdrop because again i forgot to remove it

@JordanSantiagoYT
Copy link
Owner

image
it appears to have fixed most of the issues

@Stefan2008Git
Copy link
Author

image it appears to have fixed most of the issues

Ahhh, you can remove that too. I forgot to say. What the heck wrong with me? Oh my goodness, my brain is so confused this days tho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants