-
-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve histogram docs #3101
improve histogram docs #3101
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3101 +/- ##
=======================================
Coverage 62.77% 62.77%
=======================================
Files 25 25
Lines 6426 6426
=======================================
Hits 4034 4034
Misses 2392 2392
Continue to review full report at Codecov.
|
@@ -813,7 +813,9 @@ const _examples = PlotExample[ | |||
), | |||
PlotExample( # 38 | |||
"Histogram2D (complex values)", | |||
"", | |||
""" | |||
Other possible `normed` mode include `:probability`, where bin area (volumn) is not divided. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a bit unclear to me, what you are trying to say here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the _make_hist
takes a normed
argument, the example only shows normed=true
, but under the hood, it calls the normalize!
from StatsBase
, with normalization mode default to :pdf
, but there's actually another normalization mode, which is called :probability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these modes are quite good covered in https://docs.juliaplots.org/latest/generated/attributes_series/.
This example aims to show how complex data can be visualized as a 2D Histogram.
I agree it would be good to also have a graphic that compares the different modes (like in spirit with JuliaPlots/PlotDocs.jl#217), but here is not the right place.
Adding a different example would also be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, I see, makes sense
No description provided.