make authorization a guideline rather than early exit #553
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on Slack, this is a step towards running AutoMerge on non-Registrator PRs. We also need to tweak the
if
on General to run AutoMerge on forks.Note that we don't provision the merging token unless the PR is not from a fork, so we do have some additional security from that.
The guideline shoudl help give a clear error to explain why merging is not happening.
I put the guideline near the end so we still run all the other checks (it is after the last
:update_status
).This PR does not address the fact that these PRs could be bad in ways we aren't testing for, bc we are counting on RegistryTools-based PRs. Quoting @GunnarFarneback on Slack: