Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ICU_jll to v74.1 #27

Merged
merged 5 commits into from
Dec 6, 2023
Merged

Bump ICU_jll to v74.1 #27

merged 5 commits into from
Dec 6, 2023

Conversation

qwjyh
Copy link
Contributor

@qwjyh qwjyh commented Nov 13, 2023

No description provided.

@qwjyh
Copy link
Contributor Author

qwjyh commented Nov 14, 2023

@qwjyh
Copy link
Contributor Author

qwjyh commented Nov 14, 2023

This package may need to drop support for Julia < 1.5.

@qwjyh
Copy link
Contributor Author

qwjyh commented Nov 17, 2023

Using Pkg, ICU_jll version can be obtained and this method seems to work.

diff --git a/src/StrICU.jl b/src/StrICU.jl
index e89ae6c..8634452 100644
--- a/src/StrICU.jl
+++ b/src/StrICU.jl
@@ -12,8 +12,15 @@ using ModuleInterfaceTools

 using ICU_jll

-# for now, just leave this hardcoded, until I can see how to get the version from ICU_jll
-const suffix = "_74"
+using Pkg
+function get_icu_suffix()
+    for (_, v) in Pkg.dependencies()
+        if v.name == "ICU_jll"
+            return v.version.major
+        end
+    end
+end
+const suffix = "_$(get_icu_suffix())"
 const iculib = ICU_jll.libicuuc
 const iculibi18n = ICU_jll.libicui18n

@ScottPJones ScottPJones merged commit 2e633a1 into JuliaString:master Dec 6, 2023
24 of 25 checks passed
@ScottPJones
Copy link
Member

Thank you for your PR!
I have tagged a new version of StrICU with this change (and updating the tests to use 1.6 & 1.10), as v1.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants