Update hdf5 patch install cmd #192
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch, is copied from https://github.com/live-clones/hdf5/compare/develop...billhoffman:fix-h5watch-postbuild It fixes an issue with an excessively long install command. The patch will hopefully be part of the next HDF5 release.
|
Windows build failure: https://open.cdash.org/buildSummary.php?buildid=397 |
|
Mac build succeeded: https://open.cdash.org/buildSummary.php?buildid=397 |
|
Linux build succeeded: https://open.cdash.org/buildSummary.php?buildid=5024442 |
When package was not found we would test the uppercase_FOUND, however there was a bug there which didn't test DEFINED of the variable uppercase_FOUND. The outcome was, the package wasn't found, but the macro would not error out.
|
Jenkins test this please |
|
Mac build succeeded: https://open.cdash.org/buildSummary.php?buildid=5028436 |
|
Windows build failure: https://open.cdash.org/buildSummary.php?buildid=5028451 |
|
Linux build succeeded: https://open.cdash.org/buildSummary.php?buildid=5028578 |
|
Don't merge. I can't get the updated HDF5 to allow Caffe to build yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes one of the two issues mentioned in issue #178.
The patch fixes and issue with the command line argument for an HDF5 test. The line is too long to execute with the ninja generator.