Skip to content

Commit

Permalink
Constants should use upper case letters
Browse files Browse the repository at this point in the history
Start renaming constants to use capital letters consistently.

branches_main -> BRANCHES_MAIN
  • Loading branch information
cvicentiu committed Nov 26, 2024
1 parent 07f9fdd commit 4325ee5
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions constants.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
DEVELOPMENT_BRANCH = "11.3"

# Used to trigger the appropriate main branch
branches_main = [
BRANCHES_MAIN = [
"10.5",
"10.6",
"10.11",
Expand Down Expand Up @@ -67,7 +67,7 @@
]

# Defines branches for which we save packages
savedPackageBranches = branches_main + [
savedPackageBranches = BRANCHES_MAIN + [
"bb-*-release",
"bb-10.2-compatibility",
"preview-*",
Expand Down
4 changes: 2 additions & 2 deletions master-galera/master.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ c["buildbotNetUsageData"] = None

# Configure the Schedulers, which decide how to react to incoming changes.

branches_main = ["mariadb-3.x", "mariadb-4.x", "bb-*"]
BRANCHES_MAIN = ["mariadb-3.x", "mariadb-4.x", "bb-*"]
savedPackageBranches = ["mariadb-3.x", "mariadb-4.x", "bb-*"]

# git branch filter using fnmatch
Expand All @@ -74,7 +74,7 @@ import fnmatch

def upstream_branch_fn(branch):
return (
branch in branches_main
branch in BRANCHES_MAIN
or fnmatch.fnmatch(branch, "mariadb-3.x")
or fnmatch.fnmatch(branch, "mariadb-4.x")
or fnmatch.fnmatch(branch, "bb-*")
Expand Down
2 changes: 1 addition & 1 deletion master-web/master.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ import fnmatch

def upstream_branch_fn(branch):
return (
branch in branches_main
branch in BRANCHES_MAIN
or fnmatch.fnmatch(branch, "bb-*")
or fnmatch.fnmatch(branch, "st-*")
or fnmatch.fnmatch(branch, "prot-*")
Expand Down

0 comments on commit 4325ee5

Please sign in to comment.