Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up common_factories.py #630

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Clean-up common_factories.py #630

wants to merge 1 commit into from

Conversation

cvicentiu
Copy link
Member

@cvicentiu cvicentiu commented Nov 25, 2024

This is one PR out of a sequence to refactor code in BB to make it more maintainable.

This commit should not cause any practical functional changes (to check windows builder paths).

A list of refactoring changes covered in this PR:

  1. Eliminate star imports. Import what you use.
  2. Eliminate redundant f-strings without placeholders.
  3. Fix wrong escape \ character in Windows-like paths.
  4. Eliminate (some) long lines over 80 characters.

NOTE: I HAVE NOT TESTED THIS COMMIT. It should be run in dev to ensure it works.

1. Eliminate star imports. Import what you use.
2. Eliminate redundant f-strings without placeholders.
3. Fix wrong escape \ character in Windows-like paths.
4. Eliminate (some) long lines over 80 characters.
@RazvanLiviuVarzaru
Copy link
Collaborator

Thanks, looks good.
Before merging, let me deploy your branch in Dev, test it, and I will come up on this PR with the results.

@fauust
Copy link
Collaborator

fauust commented Nov 26, 2024

Eliminate star imports. Import what you use.

👍

@cvicentiu you might want to challenge/update what's in https://github.com/MariaDB/buildbot/blob/dev/.pylintrc particularly https://github.com/MariaDB/buildbot/blob/dev/.pylintrc#L9

@cvicentiu
Copy link
Member Author

cvicentiu commented Nov 26, 2024

@fauust thanks, there are many files still using star imports, I'll keep note to disable that once all have been cleaned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants