Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wordpress: always pull latest image #635

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

grooverdan
Copy link
Member

Otherwise it keeps whatever is on the local machine.

A pull always if it gets the same manifest will still use the local cached version.

Otherwise it keeps whatever is on the local machine.

A pull always if it gets the same manifest will still
use the local cached version.
@fauust
Copy link
Collaborator

fauust commented Nov 26, 2024

Interesting, I am wondering if that would not solve the i386 problem (it does not pull latest tags either)...

@RazvanLiviuVarzaru
Copy link
Collaborator

RazvanLiviuVarzaru commented Nov 26, 2024

Interesting, I am wondering if that would not solve the i386 problem (it does not pull latest tags either)...

i386 have auto pull enabled but is buildbot that doesn't know how to handle it.
To be more precise:

Adding this + configuration options.
docker_client.pull(image, platform=self.platform)
at: https://github.com/buildbot/buildbot/blob/148802ec349866264a42c97a16cd7d3b69abd0a9/master/buildbot/worker/docker.py#L370

Reference: https://docker-py.readthedocs.io/en/stable/images.html#
Thinking of making an upstream PR when I got time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants