Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog plugin #463

Open
wants to merge 9 commits into
base: gh-pages
Choose a base branch
from
Open

Blog plugin #463

wants to merge 9 commits into from

Conversation

terry-cao
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@yandthj yandthj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet functional

Copy link
Collaborator

@yandthj yandthj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functions, but some changes still required:

  • When I click on a post, the author icon doesn't render properly on post's page on the left
  • Author icon also doesn't render properly when I click on an individual year in the Archive
  • The "Categories" tab navigates back to documentation home page.

docs/blog/posts/2021-05-06-tf.md Outdated Show resolved Hide resolved
docs/blog/posts/2021-06-18-srun.md Outdated Show resolved Hide resolved
yandthj
yandthj previously approved these changes Aug 31, 2023
Copy link
Collaborator

@yandthj yandthj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will hold merging in until demo at working group meeting

@terry-cao terry-cao dismissed yandthj’s stale review August 31, 2023 15:35

The merge-base changed after approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants