NVTX3 requires CMake 3.19+ as we set properties on INTERFACE targets #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
force-pushed
the
correct_minimum_required_cmake_version
branch
from
e2f6f73
to
15d0920
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CMake 3.19 relaxation on
INTERFACEtargets to have sources aslo removed all restrictions around which properties an INTERFACE target can have ( https://gitlab.kitware.com/cmake/cmake/-/merge_requests/5078 ). NVTX3 is adding the version property to INTERFACE targets and so requires 3.19+