Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better pkgs/by-name errors, minor fixes and improvements #290743

Merged
merged 18 commits into from
Mar 2, 2024
Merged

Better pkgs/by-name errors, minor fixes and improvements #290743

merged 18 commits into from
Mar 2, 2024

Commits on Feb 19, 2024

  1. tests.nixpkgs-check-by-name: Improve inherit detection 

    Detect inherit's better, such that a future commit can use this
information in an error message
    @infinisil
    infinisil committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    712ac79 View commit details
    Browse the repository at this point in the history

  2. tests.nixpkgs-check-by-name: Fix allowing non-path overrides 

    An edge case was allowed when it shouldn't be: A package defined in
`pkgs/by-name` could be overridden in `all-packages.nix` if it was of
the form `callPackage (<expr>) { <non-empty> }`.

This is not right, it's required that the first argument be the path
matching the package to be overridden.
    @infinisil
    infinisil committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    a61c8c9 View commit details
    Browse the repository at this point in the history

  3. tests.nixpkgs-check-by-name: Better error for non-syntactic callPackage

    @infinisil
    infinisil committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    24069b9 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. tests.nixpkgs-check-by-name: Improve error for wrong package file

    @infinisil
    infinisil committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    a53b07e View commit details
    Browse the repository at this point in the history

  2. tests.nixpkgs-check-by-name: Improve non-syntactic callPackage error … 

    …more
    @infinisil
    infinisil committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    7258d47 View commit details
    Browse the repository at this point in the history

  3. tests.nixpkgs-check-by-name: Improve more errors

    @infinisil
    infinisil committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    75cdccd View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. tests.nixpkgs-check-by-name: Improve errors relating to the base branch

    @infinisil
    infinisil committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    db7562e View commit details
    Browse the repository at this point in the history

  2. tests.nixpkgs-check-by-name: Evaluate base and main branch in parallel

    @infinisil
    infinisil committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    f5e9b88 View commit details
    Browse the repository at this point in the history

  3. tests.nixpkgs-check-by-name: More consistent errors

    @infinisil
    infinisil committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    eb1f014 View commit details
    Browse the repository at this point in the history

  4. tests.nixpkgs-check-by-name: Better error for empty second arg

    @infinisil
    infinisil committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    1c4308c View commit details
    Browse the repository at this point in the history

  5. tests.nixpkgs-check-by-name: More spaces in errors

    @infinisil
    infinisil committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    ce27178 View commit details
    Browse the repository at this point in the history

  6. tests.nixpkgs-check-by-name: Improve errors for new packages 

    Or rather, make it more consistent
    @infinisil
    infinisil committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    d2fa5ba View commit details
    Browse the repository at this point in the history

  7. tests.nixpkgs-check-by-name: Fix internal docs

    @infinisil
    infinisil committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    64da617 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. tests.nixpkgs-check-by-name: Various minor improvements 

    Co-Authored-By: Philip Taron <[email protected]>
    @infinisil @philiptaron
    infinisil and philiptaron committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    2e8d778 View commit details
    Browse the repository at this point in the history

  2. tests.nixpkgs-check-by-name: Fix absolute path in errors

    @infinisil
    infinisil committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    f056449 View commit details
    Browse the repository at this point in the history

  3. tests.nixpkgs-check-by-name: Better empty argument error

    @infinisil
    infinisil committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    7858f06 View commit details
    Browse the repository at this point in the history

  4. tests.nixpkgs-check-by-name: Use RelativePath for relative paths 

    Makes the code easier to understand and less error-prone
    @infinisil
    infinisil committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    5981aff View commit details
    Browse the repository at this point in the history

  5. tests.nixpkgs-check-by-name: More inline format! arguments 

    Now that the previous commit removed all the .display()'s that were
previously necessary for PathBuf's, but now aren't for RelativePathBuf,
we can also inline the format! arguments
    @infinisil
    infinisil committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    fb0a072 View commit details
    Browse the repository at this point in the history