-
-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] account_move_name_sequence migration to 18.0 #1954
Open
BertVGroenendael
wants to merge
61
commits into
OCA:18.0
Choose a base branch
from
DynAppsNV:18.0-mig-account_move_name_sequence
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[18.0][MIG] account_move_name_sequence migration to 18.0 #1954
BertVGroenendael
wants to merge
61
commits into
OCA:18.0
from
DynAppsNV:18.0-mig-account_move_name_sequence
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This module restores the good old behavior where journal entry numbers were generated from a sequence configured on the journal.
Add post-install script to create a sequence for all existing journals Update README accordingly
…ge lines data based on current moves
…ange_day More info about: - odoo/odoo#91019 TODO: Revert this commit after it is merged
After remove required=True for journal.sequence_id field it is possible to post an invoice with misconfigured journal with empty sequence So, this constraint will raise an error for this kind of cases since that using '/' could raise the unique constraint for all other moves
The required flag was wrong for sequence_id and refund_sequence_id So, it was not possible to store any change in journal for journal different to sale and purchase
…efix In case you want name your invoice YYYY-MM-SEQ (ie: 2022-07-00001) where: * YYYY: is the account move year * MM: is the account move month * SEQ: is a numerical sequence that is continue along the fiscal year assuming fiscal year is over two years (ie: from july to june next year) Before this commit the sequence prefix use now() to be compute but the range is selected with the account move date. This commit make consistency computing prefix with the account move date as well. So account move manage the first janunary for the last day of the previous year will properly use the account move date. Co-authored-by: Alexis de Lattre <[email protected]>
…space between name and returns.
…ence true if value not get in vals
…e" module the "_get_last_sequence" method does not have to propagate the with_prefix parameter. The sequence_prefix parameter will not be completed and will give error as it is False in this line of code. https://github.com/OCA/OCB/blob/16.0/addons/account/models/sequence_mixin.py#L169
Currently translated at 100.0% (20 of 20 strings) Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_move_name_sequence Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_move_name_sequence/fr/
Rename hooks file and use post_init_hook method to create journal sequences after module installation.
…the name The core compute function for the name is calling at the end the function self._inverse_name(), which updates the payment_reference when required. This code was currently missing, causing the payment_reference not being properly computed, for example, when using QR-Bills.
…sequence A demo ir_sequence record with 'standard' implementation was assigned to the payment journal so that no concurrency errors arise from using 'no gap' sequences when attempting to create multiple payments.
In case an alias is configured to fecth email to generate account entries. the new_message method directly call the _compute_name on account move which call the legacy code provide by account odoo module which should be avoid here. To reproduce: * configure an alias on your purchase journal * send an email to that alias * the invoice is draft with a number to mitigate this behavior the suggested patch overwritte the former method '_compute_name' and call the new implemented method '_compute_name_by_sequence'.
… thread individually"
…invoices Add demo data with standard implementation sequences In order to test locks issues without changing data (then reverting)
Split the context definition in sequence_id and refund_sequence_id fields into multiple lines to improve readability.
Update name of view files to follow guidelines.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-tools-17.0/account-financial-tools-17.0-account_move_name_sequence Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-17-0/account-financial-tools-17-0-account_move_name_sequence/
Currently translated at 100.0% (22 of 22 strings) Translation: account-financial-tools-17.0/account-financial-tools-17.0-account_move_name_sequence Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-17-0/account-financial-tools-17-0-account_move_name_sequence/it/
Currently translated at 100.0% (22 of 22 strings) Translation: account-financial-tools-17.0/account-financial-tools-17.0-account_move_name_sequence Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-17-0/account-financial-tools-17-0-account_move_name_sequence/es/
22 tasks
BertVGroenendael
force-pushed
the
18.0-mig-account_move_name_sequence
branch
3 times, most recently
from
October 21, 2024 13:37
830bc2e
to
598e640
Compare
BertVGroenendael
force-pushed
the
18.0-mig-account_move_name_sequence
branch
2 times, most recently
from
October 25, 2024 12:47
bb1c278
to
f77b14f
Compare
BertVGroenendael
force-pushed
the
18.0-mig-account_move_name_sequence
branch
from
October 31, 2024 09:22
f77b14f
to
34aa09c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.