-
-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] account_usability: Migration to 18.0 #1963
base: 18.0
Are you sure you want to change the base?
Conversation
…o account_usability
Currently translated at 100.0% (23 of 23 strings) Translation: account-financial-tools-15.0/account-financial-tools-15.0-account_usability Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-15-0/account-financial-tools-15-0-account_usability/es/
Currently translated at 100.0% (23 of 23 strings) Translation: account-financial-tools-15.0/account-financial-tools-15.0-account_usability Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-15-0/account-financial-tools-15-0-account_usability/es/
- account.tax.group views : remove views as there are now included in odoo account module - account.account.template views : port privatized views in odoo 16.0 from Odoo 15.0 CE. - account.account.tag views : adapt to V16 - account.fiscal.position.template views : add missing fields - account.group views : adapt to V16 - account.type views : remove as the model disappeared - account.chart.template views : port privatized views in odoo 16.0 from Odoo 15.0 CE. - improve documentation - FIX : remove useless duplicated fr_FR.po file - ADD : display again 'Show full accounting features' group that is hidden in CE release
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_usability Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_usability/
Currently translated at 100.0% (33 of 33 strings) Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_usability Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_usability/pt/
Currently translated at 90.9% (30 of 33 strings) Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_usability Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_usability/hr/
…n 'account.group_account_user' (and not 'account.group_account_invoice') to stick with EE design. [IMP] Documentation, adding detailled changes regarding groups in the DEVELOP.rst section.
Currently translated at 100.0% (33 of 33 strings) Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_usability Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_usability/es/
Currently translated at 90.9% (30 of 33 strings) Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_usability Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_usability/fr/
Currently translated at 100.0% (33 of 33 strings) Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_usability Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_usability/fr/
Currently translated at 100.0% (33 of 33 strings) Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_usability Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_usability/fr_FR/
Currently translated at 100.0% (33 of 33 strings) Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_usability Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_usability/fr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_usability Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_usability/
Currently translated at 100.0% (33 of 33 strings) Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_usability Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_usability/pt_BR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-tools-17.0/account-financial-tools-17.0-account_usability Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-17-0/account-financial-tools-17-0-account_usability/
Currently translated at 100.0% (16 of 16 strings) Translation: account-financial-tools-17.0/account-financial-tools-17.0-account_usability Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-17-0/account-financial-tools-17-0-account_usability/it/
32507f9
to
ed5a85f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested in runboat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@peluko00 do you know why the test are failing ? I've checked the logs but nothing came out from the logs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@legalsylvain this PR is ready for merging even if the test fail for no reason I can see. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. thanks for porting this module !
Could you cherry-pick this commit ? #1970
so the V18 module has all the latest improvment.
"2024-11-07 11:59:47,713 241 WARNING odoo odoo.tests.result: 0 failed, 0 error(s) of 0 tests when loading database 'odoo' " CC : @OCA/community-maintainers, @sbidoul, I don't remember exactly. Is it related to a new thing introduced in V18 CI ? |
The tests fail because there are no tests. |
Done! Can tou review again @legalsylvain please? |
…count_accountant module). See: https://github.com/odoo/odoo/blob/16.0/addons/account/security/account_security.xml#L4-L28 [IMP] better description of the changes
55f49f3
to
a29692b
Compare
So this will resolve itself as soon as another module with tests has been merged. |
@sbidoul I see other PRs battling this issue successfully with the following
|
@StefanRijnhart yes that works too. I don't know if the problem is prevalent (as it happens only in repos without tests) and if it's worth adding to the project template. |
I've seen it four times now. It's when modules are split up very granularly and a module without any logic is the lowest dependency in a dependency chain, it's also likely to be the first to be migrated from a repo. |
Module migrated to version 17.0
cc https://github.com/APSL 163108
@miquelalzanillas @lbarry-apsl @mpascuall @javierobcn @BernatObrador @ppyczko please review