Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP] quality_control_oca, quality_control_stock_oca #1278

Open
wants to merge 2 commits into
base: 16.0
Choose a base branch
from
Open

[16.0][IMP] quality_control_oca, quality_control_stock_oca #1278

wants to merge 2 commits into from

Conversation

AungKoKoLin1997
Copy link

@AungKoKoLin1997 AungKoKoLin1997 commented Jun 6, 2024 •
edited
Loading

Before this commit, the QC inspection was only triggered when the picking was already done. So, users could check the QC inspection only after the done state.

With this commit, the QC inspection can be triggered with three options ("Before", "Plan Ahead", and "After"). This allows the QC inspection to be triggered both when the picking is in progress and when it is done, enabling users to check the quality at any stage.

This PR does following:

  • Add date_done field in qc.inspection
    • Update date_done when status is success or fail
    • Clear date_done when status is reset to draft
  • Update form and list views to show date, and date_done
  • Add date and date_done fields in the search filter
  • Add the timing field in the QC trigger line to enable
    • When timing is 'After', an inspection is generated when a picking with the trigger is done.
    • When timing is 'Before', an inspection is generated for each related
      move when a picking with the trigger is confirmed.
    • When timing is 'Plan Ahead', a 'Plan' inspection is generated for
      each related move when a picking with the trigger is confirmed. A
      plan inspection is just a plan, and cannot be updated except for the
      date. A plan inspection gets converted into an executable inspection
      once the picking is done.

@qrtl QT4613

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-imp-quality_control_oca branch 2 times, most recently from e1f110e to e7ff281 Compare June 6, 2024 10:22
yostashiro
yostashiro reviewed Jun 6, 2024
View reviewed changes
quality_control_oca/models/qc_inspection.py Outdated Show resolved Hide resolved
quality_control_oca/views/qc_inspection_view.xml Outdated Show resolved Hide resolved
quality_control_oca/views/qc_inspection_view.xml Outdated Show resolved Hide resolved
quality_control_oca/views/qc_inspection_view.xml Outdated Show resolved Hide resolved
quality_control_oca/models/qc_inspection.py Show resolved Hide resolved
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-imp-quality_control_oca branch 4 times, most recently from b290d21 to 7eecf03 Compare June 7, 2024 09:08
yostashiro
yostashiro approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. LGTM.

Should we add a post init hook script to populate the new date_done field based on write_date or something?

@AungKoKoLin1997 AungKoKoLin1997 marked this pull request as draft June 18, 2024 04:32
@AungKoKoLin1997 AungKoKoLin1997 marked this pull request as ready for review June 18, 2024 14:31
@AungKoKoLin1997 AungKoKoLin1997 changed the title [16.0][IMP] quality_control_oca: add date_done field, update views, and add filters [16.0][IMP] quality_control_oca, quality_control_stock_oca Jun 18, 2024
yostashiro
yostashiro suggested changes Jun 19, 2024
View reviewed changes
Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can squash commits into one at this point, combining descriptions as well.

quality_control_oca/i18n/ja.po Outdated Show resolved Hide resolved
quality_control_stock_oca/tests/test_quality_control_stock.py Outdated Show resolved Hide resolved
quality_control_stock_oca/readme/CONFIGURE.rst Show resolved Hide resolved
quality_control_stock_oca/models/stock_move.py Outdated Show resolved Hide resolved
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-imp-quality_control_oca branch 2 times, most recently from d909498 to 62bbcbe Compare June 19, 2024 10:44
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-imp-quality_control_oca branch 2 times, most recently from 9a5f302 to b5ad9ad Compare June 25, 2024 05:30
@yostashiro yostashiro mentioned this pull request Jun 26, 2024
Open
yostashiro
yostashiro approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. 👍

kanda999
kanda999 approved these changes Jul 2, 2024
View reviewed changes
Copy link

@kanda999 kanda999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

1 similar comment
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@AungKoKoLin1997
Copy link
Author

@OCA-manufacture-maintainer
Could you please review this improvement PR?

AungKoKoLin1997 and others added 2 commits September 2, 2024 11:33
@AungKoKoLin1997
[IMP] quality_control_oca, quality_control_stock_oca
e40dd70 
This commit adds date_done field, update views and filters and the timing field in the QC trigger line to enable
following scenarios:

- When timing is 'Before', an inspection is generated for each related
  move when a picking with the trigger is confirmed.
- When timing is 'Plan Ahead', a 'Plan' inspection is generated for
  each related move when a picking with the trigger is confirmed. A
  plan inspection is just a plan, and cannot be updated except for the
  date. A plan inspection gets converted into an executable inspection
  once the picking is done.
@AungKoKoLin1997
[IMP] quality_control_mrp_oca: add timings
8d6f95e
@baguenth
Copy link
Member

baguenth commented Nov 18, 2024 •
edited
Loading

Hey @ChrisOForgeFlow and @JordiBForgeFlow,

this will also fix #1297 and #1396.

Can you may take a look? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanda999 kanda999 kanda999 approved these changes

@baguenth baguenth baguenth approved these changes

@yostashiro yostashiro yostashiro approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AungKoKoLin1997 @OCA-git-bot @baguenth @yostashiro @kanda999