[14.0][IMP] repair_stock_move: relate lot_id and common methods #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 28, 2024
gbrito
suggested changes
Nov 6, 2024
Hi, I can't see the comment! |
gbrito
suggested changes
Nov 6, 2024
Comment on lines
61
to
66
| if rec.move_id.move_line_ids: | ||
| rec.lot_id = ( | ||
| rec.move_id.move_line_ids[0].lot_id | ||
| if rec.move_id.move_line_ids.mapped("lot_id") | ||
| else False | ||
| ) |
There was a problem hiding this comment.
There could be an edge case if the lot_id is not assigned on the first move_line_ids.
Don't know if makes sense like this. give it a try
Suggested change
| if rec.move_id.move_line_ids: | |
| rec.lot_id = ( | |
| rec.move_id.move_line_ids[0].lot_id | |
| if rec.move_id.move_line_ids.mapped("lot_id") | |
| else False | |
| ) | |
| if rec.move_id.move_line_ids.lot_id: | |
| rec.lot_id = rec.move_id.move_line_ids.lot_id[0] | |
| else: | |
| rec.lot_id = False |
There was a problem hiding this comment.
I fixed the corner case thx! Your code give me some errors so I changed it a little bit!
The value of lot id in repair lines is not related to the one of the move related. The idea is to make them correlated to improve visibility. Also added stock_rule._get_custom_move_fields method from repair_picking as it should be added in the module that adds the field.
DavidJForgeFlow
force-pushed
the
14.0-imp-repair_stock_move
branch
from
68240fc
to
dc744bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of lot id in repair lines is not related to the one of the move related. The idea is to make them correlated to improve visibility. Also added stock_rule._get_custom_move_fields method from repair_picking as it should be added in the module that adds the field.
@ForgeFlow