[WIP][17.0] [MIG]product_configurator_sale #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng variant on default action_config_done method
…tandard Odoo modules
…d sale_management instead of sale to configurator
…_session_id in place of product_tmpl_id to call method 'create_get_variant'
…urchase : add config_session_id in place of product_tmpl_id to call method 'create_get_variant'" This reverts commit 35319829dac4ba1e61c561f5ce758e567cef090f.
…_session_id in place of product_tmpl_id to call method 'create_get_variant'
…fa-lg on sale_order)line and purchase_order_line
…or_sale: call action_next_step to open next step directly
…or_sale: remove deletion of 'view_cache'from action and change icon
…urchase: add generic method and call that
…k_next's default value true
…ines + bump version
When product configurator is installed, some other modules then fail to install. It seems that it happens when they are also extending sales order lines, to add columns to the nested tree, after the "name" field. This is probably a subtle bug in the Odoo core, but the pragmatic solution seems to simplify the Product Configurator sales order form extensions.
…get value from get_attribute_value_extra_prices
…o need to repeat which fields the method is depending on
… is raised: in _get_order_line_vals "customer_lead": product.sale_delay, AttributeError: 'product.product' object has no attribute 'sale_delay'
Chirag-OSI
changed the title
dreispt
requested changes
Feb 22, 2024
Chirag-OSI
force-pushed
the
17_mig_product_configurator_sale
branch
from
def9f8e
to
b00ae70
Compare
Chirag-OSI
force-pushed
the
17_mig_product_configurator_sale
branch
from
b00ae70
to
b5d9c31
Compare
Done |
dreispt
reviewed
Feb 26, 2024
| string="Domain", | ||
| ) | ||
| dyn_field_2_value = fields.Char() | ||
|
|
There was a problem hiding this comment.
@Chirag-OSI I don't see these field being used anywhere. Can you explain what they are for?
There was a problem hiding this comment.
@dreispt I have removed those unused fields.
|
Thank you @Chirag-OSI, will you be working on fixing the red build? |
|
I see no progress here. let me know when this is ready for review. |
|
@dreispt |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
github-actions
bot
removed
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on