[17.0] [MIG] website_product_configurator: Migration to 17.0 #143

bizzappdev · 2024-11-11T04:40:32Z

Dependency MR for module product_configurator #141
Dependency MR for module product_configurator_sale #142

…y files

…ssion

…igurator_mrp : correct method-name, claas-name, arguments

…, replace request.website.render with request.render

… not bytes)

…production_lots, fix singleton error(product.config.step.line)

…'); in js file

… website_product_configurator_mrp to uninstallable list

…ayout

…p-session

…ues in controller

… 3 days

…ata to js in specific json formate

…hange step if required field have not value

…pper function in session for next step and redirect to step if any incomplete step is there

…add 404 from website.

…sion and also get value from get_attribute_value_extra_prices

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-configurator-14.0/product-configurator-14.0-website_product_configurator Translate-URL: https://translation.odoo-community.org/projects/product-configurator-14-0/product-configurator-14-0-website_product_configurator/

rousseldenis · 2024-11-22T08:16:07Z

/ocabot migration website_product_configurator

ivantodorovich

Thanks for the work done!

I've a few minor comments, most of which are not blocking

ivantodorovich · 2024-11-25T14:08:12Z

website_product_configurator/tests/test_website_product_configurator_values.py

    def setUp(self):
-        super(TestProductConfiguratorValues, self).setUp()
+        super().setUp()


We should change this to setUpClass instead.
Looks like the base class is doing it already: https://github.com/OCA/product-configurator/blob/e78af0c423193a6e466f22567377fdcb0e1b9e46/product_configurator/tests/common.py#L5C1-L7C29

ivantodorovich · 2024-11-25T14:09:00Z

website_product_configurator/tests/test_sale_order.py

@@ -5,11 +5,17 @@

 class TestSaleOrder(TestProductConfiguratorValues):
    def setUp(self):
-        super(TestSaleOrder, self).setUp()
+        super().setUp()


We should change this to setUpClass instead.

ivantodorovich · 2024-11-25T14:10:17Z

website_product_configurator/tests/test_res_config_settings.py

@@ -3,7 +3,7 @@

 class TestResConfigSettings(TransactionCase):
    def setUp(self):
-        super(TestResConfigSettings, self).setUp()
+        super().setUp()


We should change this to setUpClass instead.

ivantodorovich · 2024-11-25T14:15:53Z

website_product_configurator/static/src/js/config_form.esm.js

@@ -0,0 +1,629 @@
+/** @odoo-module **/
+
+import Dialog from "@web/legacy/js/core/dialog";


nitpicking / not-blocking

This legacy Dialog is deprecated, and completely removed in 18.

IMO we should migrate to the new @web/core/dialog/dialog.

ivantodorovich · 2024-11-25T14:26:17Z

website_product_configurator/static/src/js/config_form.esm.js

+
+    init: function () {
+        this._super.apply(this, arguments);
+        this.config_form = $("#product_config_form");


IMO this should be in start rather than init

And ideally we should use either vanilla-js or this.$

ivantodorovich · 2024-11-25T14:47:05Z

website_product_configurator/static/src/scss/config_form.scss

+    -webkit-filter: brightness(90%) contrast(110%) grayscale(50%) opacity(50%);
+    -moz-filter: brightness(90%) contrast(110%) grayscale(50%) opacity(50%);


Suggested change

-webkit-filter: brightness(90%) contrast(110%) grayscale(50%) opacity(50%);

-moz-filter: brightness(90%) contrast(110%) grayscale(50%) opacity(50%);

not needed

ivantodorovich · 2024-11-25T14:47:10Z

website_product_configurator/static/src/scss/config_form.scss

+    -webkit-filter: brightness(90%) contrast(110%) grayscale(50%) opacity(50%);
+    -moz-filter: brightness(90%) contrast(110%) grayscale(50%) opacity(50%);


Suggested change

-webkit-filter: brightness(90%) contrast(110%) grayscale(50%) opacity(50%);

-moz-filter: brightness(90%) contrast(110%) grayscale(50%) opacity(50%);

not needed

ivantodorovich · 2024-11-25T14:47:15Z

website_product_configurator/static/src/scss/config_form.scss

+    -webkit-filter: none;
+    -moz-filter: none;


Suggested change

-webkit-filter: none;

-moz-filter: none;

not needed

ivantodorovich · 2024-11-25T14:47:21Z

website_product_configurator/static/src/scss/config_form.scss

+    -webkit-filter: none;
+    -moz-filter: none;


Suggested change

-webkit-filter: none;

-moz-filter: none;

not needed

ivantodorovich · 2024-11-25T14:49:57Z

website_product_configurator/README.md

@@ -0,0 +1,3 @@
+#Odoo Product Configurator
+
+This module facilitates to configure product on website.


Could you replace this with proper "readme section files" under a readme directory? 🙏🏻

PCatinean and others added 30 commits November 8, 2024 19:08

Removed console.log, renamed __openerp__.py files to __manifest__.py

8f2750b

Bumped version to 11.0 and removed all traces of coding: utf-8 from p…

90d6bce

…y files

Update README, replace iteritems->items, minor fixes

8aea70f

Moving config step related methods from product template to config se…

5457bf0

…ssion

[FIX]product_configurator, website_product_configurator, product_conf…

32dea04

…igurator_mrp : correct method-name, claas-name, arguments

[FIX]website_product_configurator : replace val._model with val._name…

ff29a52

…, replace request.website.render with request.render

[FIX]website_product_configurator : fix error(TypeError: must be str,…

8cac077

… not bytes)

[FIX][T1902] : fix singleton error(product.config.session), fix view …

1681f27

…production_lots, fix singleton error(product.config.step.line)

[FIX][T1902]website_product_configurator : add require('web.dom_ready…

336f68b

…'); in js file

Added product_configurator_stock and website_product_configurator and…

e534b6f

… website_product_configurator_mrp to uninstallable list

[WIP] Migration and refactor of website product configurator

62e5e21

[IMP] Moved render methods to controller

3d95b67

[IMP] Added published widget to form view, basic configuration view l…

6741035

…ayout

First version of descentralized forms for all config steps

c218b2b

[FIX] Checking for selected values properly, added header

3d43ed2

[IMP] Preparing basic onchange and adding tour tests

ac71bde

[IMP]website_product_configurator: save product-config-session in htt…

b3b5cfd

…p-session

[IMP]create new session each time only for public user

58fe037

[WIP]website_product_configurator : call onchange and get changed val…

0f52120

…ues in controller

[IMP]add cron to delete cofig session that are inactive for more than…

e5c5723

… 3 days

[WIP]add code to handle multi attribute and call onchange, and send d…

6d23b74

…ata to js in specific json formate

[FIX]create session for public user if session will create with no login

7795a71

[IMP]make steps lines visible and invisible based on open step lines

5d880ac

[IMP]save data in session and add functionality of continue

2231280

[IMP]remove invalid selection on onchage

d07f53d

[IMP]configure product and save step in session

08ca2d5

[IMP]website_product_configurator : redirect product and prevent to c…

7a2105c

…hange step if required field have not value

[IMP]product_configurator, website_product_configurator : write a wra…

e6ad6d5

…pper function in session for next step and redirect to step if any incomplete step is there

[IMP]website_product_configurator : move code in small methods in js

1a8e268

[IMP]add code for custom values

90f586b

pledrateam and others added 15 commits November 8, 2024 19:08

[FIX] website_product_configurator : fix the image for attribute and …

94e4207

…add 404 from website.

[FIX] website_product_configurator : fix website page and image url.

6b5876c

[FIX] write testcase for website_product_configurator

08d2704

[UPD] Update website_product_configurator.pot

66d0cf1

[FIX]website_product_configurator: fix issue of cfg_product

c151af1

website_product_configurator 14.0.1.1.0

8bd44aa

Add pcatinean as maintainer for all modules

d0d8dd6

[WIP][T-01839]product_configurator: remove price calculation from ses…

db2b4d7

…sion and also get value from get_attribute_value_extra_prices

[REF] *: fix PCatinean maintainer

5a52a1a

website_product_configurator 14.0.1.1.1

68db648

[IMP] cron noupdate

9f4fa7d

website_product_configurator 14.0.1.2.0

2666b0c

[IMP] update dotfiles [ci skip]

b5ee56e

[IMP] website_product_configurator: pre-commit auto fixes

59619e5

bizzappdev force-pushed the 17.0-mig-website_product_configurator-BAD branch 3 times, most recently from 1b752da to 92a1065 Compare November 22, 2024 05:40

bizzappdev marked this pull request as ready for review November 22, 2024 05:46

bizzappdev mentioned this pull request Nov 22, 2024

[MIG][17.0] product_configurator: Migration to 17.0 #141

Merged

bizzappdev force-pushed the 17.0-mig-website_product_configurator-BAD branch from 92a1065 to 6e04543 Compare November 22, 2024 07:03

OCA-git-bot added this to the 17.0 milestone Nov 22, 2024

OCA-git-bot mentioned this pull request Nov 22, 2024

Migration to version 17.0 #99

Open

3 tasks

rousseldenis added migration needs review labels Nov 22, 2024

bizzappdev added 2 commits November 25, 2024 14:40

[MIG][17.0] website_product_configurator:Migration to 17.0

9003b30

[DON'T MERGE] test-requirements.txt

1542af4

bizzappdev force-pushed the 17.0-mig-website_product_configurator-BAD branch from 6e04543 to 1542af4 Compare November 25, 2024 09:12

ivantodorovich approved these changes Nov 25, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0] [MIG] website_product_configurator: Migration to 17.0 #143

[17.0] [MIG] website_product_configurator: Migration to 17.0 #143

bizzappdev commented Nov 11, 2024

rousseldenis commented Nov 22, 2024

ivantodorovich left a comment

ivantodorovich Nov 25, 2024

ivantodorovich Nov 25, 2024

ivantodorovich Nov 25, 2024

ivantodorovich Nov 25, 2024

ivantodorovich Nov 25, 2024

ivantodorovich Nov 25, 2024

ivantodorovich Nov 25, 2024

ivantodorovich Nov 25, 2024

ivantodorovich Nov 25, 2024

ivantodorovich Nov 25, 2024

		@@ -0,0 +1,629 @@
		/ @odoo-module /

		import Dialog from "@web/legacy/js/core/dialog";

		-webkit-filter: brightness(90%) contrast(110%) grayscale(50%) opacity(50%);
		-moz-filter: brightness(90%) contrast(110%) grayscale(50%) opacity(50%);

		@@ -0,0 +1,3 @@
		#Odoo Product Configurator

		This module facilitates to configure product on website.

[17.0] [MIG] website_product_configurator: Migration to 17.0 #143

Are you sure you want to change the base?

[17.0] [MIG] website_product_configurator: Migration to 17.0 #143

Conversation

bizzappdev commented Nov 11, 2024

rousseldenis commented Nov 22, 2024

ivantodorovich left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment