-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol-designer, app, api): step grouping foundation #15737
base: edge
Are you sure you want to change the base?
Conversation
A PR has been opened to address analyses snapshot changes. Please review the changes here: https://github.com/Opentrons/opentrons/pull/ |
1 similar comment
A PR has been opened to address analyses snapshot changes. Please review the changes here: https://github.com/Opentrons/opentrons/pull/ |
9f72818
to
b1a30ae
Compare
A PR has been opened to address analyses snapshot changes. Please review the changes here: https://github.com/Opentrons/opentrons/pull/ |
2 similar comments
A PR has been opened to address analyses snapshot changes. Please review the changes here: https://github.com/Opentrons/opentrons/pull/ |
A PR has been opened to address analyses snapshot changes. Please review the changes here: https://github.com/Opentrons/opentrons/pull/ |
6e7020d
to
f3e3a19
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #15737 +/- ##
==========================================
- Coverage 63.31% 63.18% -0.13%
==========================================
Files 300 288 -12
Lines 15773 15276 -497
==========================================
- Hits 9986 9652 -334
+ Misses 5787 5624 -163
Flags with carried forward coverage won't be shown. Click here to find out more. |
f3e3a19
to
3a9212a
Compare
for command_annotation in protocol.commandAnnotations | ||
] | ||
else: | ||
raise ValueError("Uh oh") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably needs real error :P
addresses AUTH-573
Overview
co-authored by @jbleon95
This is the foundation for Step grouping in the system. Step grouping is part of the PD redesign follow-up (originally it was part of the PD redesign but got descoped a few days ago. it IS still part of the redesign plans but will be in a follow up): https://opentrons.atlassian.net/wiki/spaces/RPDO/pages/4331339778/WIP+Step+Grouping+Architecture+Proposal+for+JSON+protocols+only
The way step grouping works is the user in PD adds the step to a group and that information gets parsed into
commandAnnotations
in the schema as part of asecondOrderCommand
.When uploading the protocol to the app, the
commandAnnotations
is part of theCompletedProtocolAnalysis
which is displayed in the Timeline tab inProtocolDetails
- only on the desktop app. Note that the Timeline tab is only visible if you have theProtocol timeline
feature flag turned on.Screen.Recording.2024-09-16.at.10.32.48.mov
Test Plan
NOTE: this is just the foundation and there are definitely bugs (i.e, if you delete a step in a group it will whitescreen right now). What you should be able to do is:
Protocol timeline
ff is turned on and go to the "timeline" tab in protocol details. You should see the group displayed.Changelog
RootState
in PD (unsavedGroup
,stepGroups
)AnnotatedSteps
in the app to display the steps in the groupcommandAnnotations
to show up in theCompletedProtocolAnalysis
Review requests
Risk assessment
low, behind ff in app and in PD