feat(api): add new InstrumentContext.transfer_liquid() method #16819
+924
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes AUTH-843
Overview
Adds
InstrumentContext.transfer_liquid()
method that does the following-transfer_liquid()
This PR does not cover engine core's transfer method execution.
Test Plan and Hands on Testing
Since this is mostly adding the scaffolding to implement the actual execution of transfer method, this PR is not testable on the robot yet. Unit tests are crucial at this stage and have been added for all changes.
Changelog
InstrumentContext.transfer_liquid()
InstrumentCore.load_liquid_class()
and a placeholderInstrumentCore.transfer_liquid()
protocol_api.validation
that get used inInstrumentContext.transfer_liquid()
as_schema_v1_model()
to the liquid properties in order to fetch the pydantic model representation of the liquid class's properties. This is used byload_liquid_class()
in order to create aliquidClassRecord
Review requests
Do the validations make sense? Am I missing anything?
Does the
transfer_liquid()
interface look good?Risk assessment
No risk so far since this is a code-only change.