tmp:fix bugs for vis-formula; test=develop #10528
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
| @@ -35,7 +35,7 @@ static void GetBroadcastDimsArrays(const DDim &x_dims, | |||
| }; | |||
|
|
|||
| CHECK_GE(axis, 0); | |||
| CHECK_LT(axis, max_dim); | |||
| CHECK_LE(axis, max_dim); | |||
There was a problem hiding this comment.
int max_dim = (std::max)(dim_x.size(), dim_y.size()); int axis = std::abs(static_cast<int>(dim_x.size() - dim_y.size()));
但是这里出现了dim_x.size() = 0 的情况，导致axis= 1 && max_dim =1,并且x还并不是一个0dim的scalar，暂时没有追到根因，这里先放开一下供业务临时使用，暂不合入
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR devices
XPU
PR types
Bug fixes
PR changes
OP
Description
临时修复vis-公式模型的一些bug，基于一下pr：
https://github.com/PaddlePaddle/Paddle-Lite/pull/10527/files
https://github.com/PaddlePaddle/Paddle-Lite/pull/10431/files