Bugfix for local repo casing issue on Linux #1750
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anamnavi
changed the title
anamnavi
commented
Nov 12, 2024
src/code/LocalServerApiCalls.cs
Outdated
| @@ -260,7 +260,7 @@ private FindResults FindNameHelper(string packageName, string[] tags, bool inclu | |||
| string actualPkgName = packageName; | |||
|
|
|||
| // this regex pattern matches packageName followed by a version (4 digit or 3 with prerelease word) | |||
| string regexPattern = $"{packageName}" + @".\d+\.\d+\.\d+(?:[a-zA-Z0-9-.]+|.\d)?.nupkg"; | |||
| string regexPattern = $"{packageName}" + @"\.\d+\.\d+\.\d+(?:[a-zA-Z0-9-.]+|.\d)?.nupkg"; | |||
There was a problem hiding this comment.
Does this account for 2 digit versions
|
Other than the digit issue, everything else looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the FindNameHelper() the regex was:
test_local_mod.\d+.\d+.\d+(?:[a-zA-Z0-9-.]+|.\d)?.nupkg
The first '.' matches any character whereas our intention with the regex is to match the literal '.' so I added a backslash before the '.' to escape it. If the package being searched for is
test_local_modit was matching test_local_mod.1.0.0.nupkg and also test_local_mod_2.1.0.0.nupkg where the '_' character was getting matched by '.' in regexand
2.1.0.0was getting considered as the version.The main issue Amber had found was that for FindVersionHelper() the path for the .nupkg was being constructed and we use lowercasing so on Linux that path will not be correct. Instead, once we find a matching package (by name and version) we should use the
pathgiven from the file system that has the correct casing.PR Summary
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.