-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update notebook requirements #2382
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
16afd8c
to
4af95dd
Compare
One or more of the following people are relevant to this code:
|
This failed once due to a notebook kernel dying, see https://github.com/Qiskit/documentation/actions/runs/12015838807/job/33494742907. I'm not sure why and can't reproduce. It worked fine when I re-ran the job. |
I've seen that kernel death error a few times. I opened #2387 to track that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
The problem is `service.jobs()` by default only gets the past 10 jobs. Usually this is fine, but there's a chance the past 10 jobs we've submitted have all been cancelled or have failed. This PR reduces the change of CI failing by increasing the number of jobs we collect. We can remove the limit by setting `limit=None`, but this takes too long to execute. I've picked 1000 as a compromise. *** This is ready for review, but don't merge until after #2382 is merged. When that happens, I'll pull main and re-run this notebook to update it.
Closes #2374
This PR makes a few changes: