Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notebook requirements #2382

Merged
merged 6 commits into from
Nov 25, 2024
Merged

Update notebook requirements #2382

merged 6 commits into from
Nov 25, 2024

Conversation

frankharkins
Copy link
Member

@frankharkins frankharkins commented Nov 25, 2024

Closes #2374

This PR makes a few changes:

  1. Update our Python dependencies to the latest versions (0864f5a)
  2. Fix the serverless notebooks (f686f24, 6405a0e). These were actually broken but we didn't catch it because we only test that the program uploads correctly, not that it runs. I thought I'd added tests for this but I'm not sure what happened to them.
  3. Re-run all noteboooks with the new requirements (77f0c10, 4af95dd).

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@qiskit-bot
Copy link
Contributor

One or more of the following people are relevant to this code:

@frankharkins
Copy link
Member Author

This failed once due to a notebook kernel dying, see https://github.com/Qiskit/documentation/actions/runs/12015838807/job/33494742907. I'm not sure why and can't reproduce. It worked fine when I re-ran the job.

@Eric-Arellano
Copy link
Collaborator

I've seen that kernel death error a few times. I opened #2387 to track that

Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@frankharkins frankharkins added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit 2a30a83 Nov 25, 2024
4 checks passed
@frankharkins frankharkins deleted the FH/notebook-ci branch November 25, 2024 19:41
github-merge-queue bot pushed a commit that referenced this pull request Nov 26, 2024
The problem is `service.jobs()` by default only gets the past 10 jobs.
Usually this is fine, but there's a chance the past 10 jobs we've
submitted have all been cancelled or have failed.

This PR reduces the change of CI failing by increasing the number of
jobs we collect. We can remove the limit by setting `limit=None`, but
this takes too long to execute. I've picked 1000 as a compromise.

***

This is ready for review, but don't merge until after #2382 is merged.
When that happens, I'll pull main and re-run this notebook to update it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Upgrade notebook dependencies
3 participants