Fix changed files check for APIs in CI #2389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
changed the title
Eric-Arellano
changed the title
|
You can see a successful run at https://github.com/Qiskit/documentation/actions/runs/12018028777/job/33501631056#step:19:7 |
arnaucasau
approved these changes
Nov 25, 2024
| "Read the file path for file paths and globs to check, like `docs/start/index.md`. Entries should be separated by a newline and should be valid file types (.md, .mdx, .ipynb).", | ||
| "Read the file path for file paths and globs to check, like `docs/start/index.md`. " + | ||
| "Entries should be separated by a newline and should be valid file types (.md, .mdx, .ipynb)." + | ||
| "Mutually exclusive with the other args.", |
There was a problem hiding this comment.
Nice comment! Maybe in the future, we can refactor it and use .conflcts() to error if --from-file is used with another argument to avoid setting them unintentionally.
There was a problem hiding this comment.
I think, in 5b57701, we also need to remove the default: false from the other arguments and let them be undefined. Otherwise, they count as set by conflicts and the option from-files will always error
Co-authored-by: Arnau Casau <[email protected]>
This was referenced Nov 25, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 26, 2024
#2389 (comment) Co-authored-by: Arnau Casau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two issues:
--from-filewas being combined with the other args.echothe changed files to save them could blow up the overall GitHub Action when there were too many files. Instead, we can use the changed-files action to write the output directly.