Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameter handling for NLocal(..., flatten=True) and standard gates (backport #13482) #13495

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 26, 2024

Summary

Fixes #13478.

The fast-path for parameterizing standard gates caused an inconsistent state of the circuit, which is now fixed by using the explicit circuit._append_standard_gate method.

Details and comments

I'm not 100% sure what exactly the inconsistency was. Another way to fix this issue was to have the Rust-side assign_parameter_inner to explicitly re-assign the params attribute of the cached Python gate. So I'm assuming the old path didn't correctly register the gate in the cache, but I couldn't pin point the exact location in the code. If someone has more insight that would be great to know 🙂


This is an automatic backport of pull request #13482 done by [Mergify](https://mergify.com).

…ates (#13482)

* Use _append_standard_gate directly

* update params on cache

* Revert "Use _append_standard_gate directly"

This reverts commit 9769785.

* Add test and reno

(cherry picked from commit 4e5d9f8)
@mergify mergify bot requested a review from a team as a code owner November 26, 2024 20:36
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Cryoris
  • @Qiskit/terra-core
  • @ajavadia

@github-actions github-actions bot added Changelog: Bugfix Include in the "Fixed" section of the changelog mod: circuit Related to the core of the `QuantumCircuit` class or the circuit library labels Nov 26, 2024
@github-actions github-actions bot added this to the 1.3.0 milestone Nov 26, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12038616619

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 88.934%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 4 92.98%
Totals Coverage Status
Change from base Build 12027471253: 0.02%
Covered Lines: 79071
Relevant Lines: 88910

💛 - Coveralls

@mtreinish mtreinish added this pull request to the merge queue Nov 26, 2024
Merged via the queue into stable/1.3 with commit 2069b83 Nov 26, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog mod: circuit Related to the core of the `QuantumCircuit` class or the circuit library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants