feat: display timezone adjusted time range in time picker #6521
Conversation
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to b66328e in 30 seconds
More details
- Looked at
66lines of code in2files - Skipped
0files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. frontend/src/components/CustomTimePicker/RangePickerModal.tsx:65
- Draft comment:
Ensure that thedayjstimezone plugin is loaded before usingdayjs.tz. This is necessary for the timezone adjustments to work correctly. This applies to all instances wheredayjs.tzis used. - Reason this comment was not posted:
Comment did not seem useful.
2. frontend/src/container/TopNav/DateTimeSelectionV2/index.tsx:670
- Draft comment:
Ensure that thedayjstimezone plugin is loaded before usingdayjs.tz. This is necessary for the timezone adjustments to work correctly. This applies to all instances wheredayjs.tzis used. - Reason this comment was not posted:
Marked as duplicate.
3. frontend/src/container/TopNav/DateTimeSelectionV2/index.tsx:614
- Draft comment:
Avoid using inline styles in React components. Instead, use external stylesheets, CSS classes, or styled components. This issue is also present in other parts of the code. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_DPmojYGctva1U4OQ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
4 similar comments
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
…zone picker by clicking outside (#6522)
YounixM
merged commit 89cb5af
into
feat/timezone-formatter-custom-hook-and-adjust-graphs-timezone
Summary
Related Issues / PR's
Part of https://github.com/SigNoz/engineering-pod/issues/2005
Screenshots
Before:
2024-11-25.09-22-49.mov
After:
2024-11-25.09-21-49.mov
Affected Areas and Manually Tested Areas