Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add telemetry for trace migration #6537

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

nityanandagohain
Copy link
Member

@nityanandagohain nityanandagohain commented Nov 26, 2024

Part of https://github.com/SigNoz/engineering-pod/issues/2036

  • Collect the TTL for metrics, traces, logs
  • Collect number of dashboards and alerts having trace clickhouse query

Important

Enhances telemetry by collecting TTLs and counting dashboards and alerts with trace ClickHouse queries.

  • Telemetry Enhancements:
    • Collects TTL for metrics, traces, and logs in telemetry.go.
    • Counts dashboards and alerts with trace ClickHouse queries in model.go and db.go.
  • Functions Added:
    • isDashboardWithTracesClickhouseQuery() in model.go to identify dashboards with trace queries.
  • Data Models:
    • Adds DashboardsWithTraceChQuery and AlertsWithTraceChQuery to DashboardsInfo and AlertsInfo in response.go.

This description was created by Ellipsis for 6eaa3ff. It will automatically update as commits are pushed.

@github-actions github-actions bot added the bug Something isn't working label Nov 26, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 6eaa3ff in 2 minutes and 10 seconds

More details
  • Looked at 148 lines of code in 4 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. pkg/query-service/app/dashboards/model.go:468
  • Draft comment:
    Logical error: dashboardsInfo.MetricBasedPanels += dashboardsInfo.MetricBasedPanels should be dashboardsInfo.MetricBasedPanels += dashboardInfo.MetricBasedPanels.
  • Reason this comment was not posted:
    Comment was on unchanged code.
2. pkg/query-service/app/dashboards/model.go:503
  • Draft comment:
    Avoid using inline styles in React components. Use external stylesheets, CSS classes, or styled components instead. This is also applicable in other parts of the code.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_OjwFB0jr8LWEpqa3


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@srikanthccv
Copy link
Member

Collect the TTL for metrics, traces, logs

This is not done

@nityanandagohain
Copy link
Member Author

@srikanthccv check pkg/query-service/telemetry/telemetry.go , we are sending the TracesTime

@nityanandagohain nityanandagohain merged commit a3e57a1 into develop Nov 26, 2024
14 of 16 checks passed
@nityanandagohain nityanandagohain deleted the fix/issue_2036 branch November 26, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants