Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(documentation): network flow documentation #1837

Merged
merged 8 commits into from
Sep 18, 2023

Conversation

Jose-Matsuda
Copy link
Contributor

Closes
https://github.com/StatCan/aaw-private/issues/128

Note that this documentation will need to be updated as the ### Allow Connection to internal application in an already peered network does not fully work

Souheil-Yazji
Souheil-Yazji previously approved these changes Sep 12, 2023
Copy link
Contributor

@Souheil-Yazji Souheil-Yazji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/dev/resources/networking.md Show resolved Hide resolved
@Jose-Matsuda
Copy link
Contributor Author

I've made more changes in response to Pat's comments and I think it's in a good state.
The other thing mentioned on slack was only having main topics of;

  1. Adding Application Firewall Rule
  2. Adding Network Firewall Rule
  3. DNS

but admittedly, I've grown attached to my version and I think it serves the purpose of having an obvious example that developers who may not be too into the weeds (like myself) would gravitate to more.

Copy link
Contributor

@chuckbelisle chuckbelisle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank @vexingly for the comments and prior review. Also thank you to @Jose-Matsuda for creating this documentation.

@chuckbelisle chuckbelisle merged commit c089f3e into master Sep 18, 2023
0 of 2 checks passed
@chuckbelisle chuckbelisle deleted the 128-networking-update branch September 18, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants