-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(documentation): network flow documentation #1837
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I've made more changes in response to Pat's comments and I think it's in a good state.
but admittedly, I've grown attached to my version and I think it serves the purpose of having an obvious example that developers who may not be too into the weeds (like myself) would gravitate to more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thank @vexingly for the comments and prior review. Also thank you to @Jose-Matsuda for creating this documentation.
Closes
https://github.com/StatCan/aaw-private/issues/128
Note that this documentation will need to be updated as the
### Allow Connection to internal application in an already peered network
does not fully work