Ensure array_type has front() method + fix array_type on jsoncpp

[omar-mohamed-khallaf]

Replace front() with [0] in get_x5c_key_value as front is not supported by jsoncpp on array types.

[prince-chrismc]

Would it be possible to implement the missing function in the trait definition?

Extending,

jwt-cpp/include/jwt-cpp/traits/open-source-parsers-jsoncpp/traits.h

Line 16 in 83703d7

class array_type : public Json::Value {

Also it seems we are missing this function as a requirement for the json array

jwt-cpp/include/jwt-cpp/jwt.h

Line 2459 in 83703d7

struct is_valid_json_array {

[omar-mohamed-khallaf]

Is front() the missing function for the second issue, or something else?

[prince-chrismc]

Yes, front() Should be checked.

Might also be worth checking if the unit tests are missing a case 🤔 we just dint run the unit tests with JSON libraries

jwt-cpp/.github/workflows/traits.yml

Line 59 in 83703d7

- name: test

Notes:

jwt-cpp/example/jwks-verify.cpp

Line 111 in 83703d7

auto x5c = jwk.get_x5c_key_value();

jwt-cpp/tests/JwksTest.cpp

Line 117 in 83703d7

ASSERT_EQ(jwk3.get_x5c_key_value(), "1");

[omar-mohamed-khallaf]

Yes, front() Should be checked.

I added this line !std::is_same<decltype(std::declval<array_type>().front()), void>::value to is_valid_json_array, is it ok?

std::is_member_function_pointer had problems resolving the overloaded front function, and I had no idea how to solve it.

[prince-chrismc]

Amazing work, thanks for helping to fix this!

[prince-chrismc]

Looks like a type error in the Danieljson changes from the CI

[omar-mohamed-khallaf]

Something is wrong in the current implementation.

static object_type as_object(const json& val) {
	if (val.type() != jsoncons::json_type::object_value) throw std::bad_cast();
	return object_type(val.object_value());
}

static array_type as_array(const json& val) {
	if (val.type() != jsoncons::json_type::array_value) throw std::bad_cast();
	return val.array_value();
}

These two functions use val.object_value() and val.array_value(), but I can't find any reference to these functions in the jsoncons library.

[omar-mohamed-khallaf]

The problem existed before the current modifications.
Should it be fixed in a new PR?