fix(subscriber): handle concurrent call to close correctly #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It appears that the current implementation of
Closedoesn't handle very well concurrent call. Indeed as it is written it allows for two goroutines calling close at the same time to havegetClosedreturn true.This is causing ThreeDotsLabs/watermill#351 I believe.
I propose this patch to actually use an
atomic.Boolto keep track of theclosedstate. I think that doing this allows to prevent the issue that we're seeing.I'm opening this as a draft for now, I would like to deploy this change and make sure it fixes something :)