Renovateの設定を直す #637
Merged
Renovateの設定を直す #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qryxip
force-pushed
the
update-renovate-config
branch
3 times, most recently
from
7ed1f86
to
8d088a7
Compare
qryxip
force-pushed
the
update-renovate-config
branch
from
8d088a7
to
bfdbd82
Compare
|
なんかこれで大丈夫そうなのでdraft外します。 |
qryxip
commented
Oct 11, 2023
Comment on lines
-10
to
+22
| "regexManagers": [ | ||
| "customManagers": [ | ||
| { | ||
| "customType": "regex", |
There was a problem hiding this comment.
regexManagerというのは古く、今はcustomManagersというらしい。
| "groupSlug": "others", | ||
| "groupName": "Others", | ||
| "excludePackagePatterns": "^Rust$", | ||
| "dependencyDashboardApproval": true |
There was a problem hiding this comment.
これで明示的にdashboardから起動しない限り、PR以前にpushもされなくなるらしい。
(実際branchも作られなくなった)
これがfalse(デフォルト値)だと、このようなPRが飛んでくる。
qryxip#8
| "fileMatch": [ | ||
| "^rust-toolchain$" | ||
| ], | ||
| "matchStrings": [ | ||
| "(?<currentValue>\\d+\\.\\d+\\.\\d+)" | ||
| ], | ||
| "depNameTemplate": "Rust", | ||
| "lookupNameTemplate": "rust-lang/rust", | ||
| "packageNameTemplate": "rust-lang/rust", |
There was a problem hiding this comment.
lookupNameTemplateというのはドキュメントにもschemaにもなく、Renovateの実装から拾ってきたものであるが、packageNameTemplate (ちゃんとドキュメントもある)でその役割ができるらしいので置き換え。
Hiroshiba
approved these changes
Oct 12, 2023
|
VSCodeがデフォルトでjson5ダメだったので諦めました 😇 今回の設定だとRustはOK、Rust以外はなしという形ですが、一律でなしにしたあとRustだけOKにする形もできるのかなとちょっと思いました。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
#470 (comment)をなんとかします。
関連 Issue
ref #470
その他
fork(qryxip/voicevox_core)での確認はこれからします。